Move some args into ... #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
feel free to merge whenever and i'll submit to CRAN afterwards :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #642 +/- ##
==========================================
+ Coverage 52.39% 52.41% +0.01%
==========================================
Files 65 65
Lines 5334 5334
==========================================
+ Hits 2795 2796 +1
+ Misses 2539 2538 -1 ☔ View full report in Codecov by Sentry. |
|
Tests are failing for unrelated reasons. @DominiqueMakowski you can merge and submit (: |
|
Remember to bump to a correct version on the description file 😉 |
me? You mean when I submit? Wait I feel like I forgot everything, can you write explicitly about what I should make sure of 🙈 |
|
Can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.